| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: pg14 psql broke \d datname.nspname.relname |
| Date: | 2022-04-20 20:38:33 |
| Message-ID: | CA+hUKGLrUuNGQDn3WDjZojiL4MrOor9XXUE5rhQvHfJLGChLbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 21, 2022 at 7:35 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Apr 20, 2022 at 3:08 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Looks like this somehow broke on a Windows box:
> >
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2022-04-20%2016%3A34%3A19
>
> So the issue here is that we are running this command:
>
> pg_dumpall --exclude-database .*
>
> And on that Windows machine, .* is being expanded to .gitignore, so
> pg_dumpall prints:
>
> pg_dumpall: error: improper qualified name (too many dotted names): .gitignore
>
> Instead of:
>
> pg_dumpall: error: improper qualified name (too many dotted names): .*
>
> I don't know why that glob-expansion only happens on jacana, and I
> don't know how to fix it, either.
Perhaps bowerbird and jacana have different versions of IPC::Run? I
see some recent-ish changes to escaping logic in here from Noah:
https://github.com/toddr/IPC-Run/commits/master/lib/IPC/Run/Win32Helper.pm
Looks like the older version looks for meta characters not including
'*', and the later one uses Win32::ShellQuote::quote_native.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-04-20 20:45:27 | renumber_oids.pl needs some updates |
| Previous Message | Tom Lane | 2022-04-20 20:29:28 | Re: Replace open mode with PG_BINARY_R/W/A macros |