Re: pgsql: Add standard collation UNICODE

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add standard collation UNICODE
Date: 2023-03-12 22:47:32
Message-ID: CA+hUKGLmKe1KMhiU4nwcq-d-V7MWec8NVjCivnq6tHyQUdQwfg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Mar 13, 2023 at 9:10 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > On 2023-03-11 Sa 15:47, Tom Lane wrote:
> >> In general, I see no good reason for our regression tests to be making
> >> assumptions about exactly how ICU's root locale behaves, so I'd suggest
> >> just lobotomizing this test case so it doesn't depend on upper/lower
> >> sort order.
>
> > Yeah, I think we've found enough cases in old still not dead distros to
> > make this reasonable.
>
> I see topminnow is showing the symptom too, so it's now pretty clear
> that this was once a common behavior. I dug in ICU's release notes
> and couldn't find anything about it, but they must've changed something
> somewhen.

Most odd, and a bit worrying for the multi-lib concept we were
discussing (now for 17), though not fatal if it's something like
"there was one historical screwup back in 50.whatever, but now we are
more careful", or "it was a packaging error that was fixed but old
systems that aren't getting updated don't have the fix", so not even
ICU's fault (which would fit with Jeff's observation that he can't
repro the issue by building from ICU source at the 50.2 tag, as if
what is in the package is not what was tagged?!). It'd be nice to
understand what happened here... What do these disagreeing systems
report for the various version meta-data (Unicode version, CLDR
version, the opaque collator version, etc)?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-03-13 04:05:04 pgsql: Refactor and improve tests of pg_walinspect
Previous Message Tom Lane 2023-03-12 20:10:02 Re: pgsql: Add standard collation UNICODE