Re: pgsql: Don't trust unvalidated xl_tot_len.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Date: 2023-11-10 22:05:48
Message-ID: CA+hUKGLm3+2NZX1pEv+2Ky+MmD+nLeBxsNxKYtowepHUnbg8FQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Nov 11, 2023 at 10:42 AM Christoph Berg <myon(at)debian(dot)org> wrote:
> > I haven't investigated the details yet, and it's not affecting the
> > builds on apt.postgresql.org, but the Debian amd64 and i386 regression
> > tests just failed this test on PG13 (11 and 15 are ok):
>
> 12 and 14 are also failing, now on Debian unstable. (Again, only in
> the salsa.debian.org tests, not on apt.postgresql.org's buildds.)
>
> 12 amd64: https://salsa.debian.org/postgresql/postgresql/-/jobs/4898857
> 12 i386: https://salsa.debian.org/postgresql/postgresql/-/jobs/4898858
>
> The tests there are running in Docker containers.

Hmm. regress_log_039_end_of_wal says:

No such file or directory at
/builds/postgresql/postgresql/debian/output/source_dir/build/../src/test/perl/TestLib.pm
line 655.

In the 13 branch we see that's in the new scan_server_header()
subroutine where it tries to open the header, after asking pg_config
--includedir-server where it lives. Hmm...

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2023-11-11 11:53:37 Re: pgsql: Don't trust unvalidated xl_tot_len.
Previous Message Christoph Berg 2023-11-10 21:42:26 Re: pgsql: Don't trust unvalidated xl_tot_len.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-10 22:47:45 Re: Failure during Building Postgres in Windows with Meson
Previous Message John Morris 2023-11-10 21:49:06 Re: locked reads for atomics