| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Mark Dilger <hornschnorter(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Should we add xid_current() or a int8->xid cast? |
| Date: | 2020-04-16 17:56:58 |
| Message-ID: | CA+hUKGLgE56triYvf4ocPH7e=oJa-0RLPxpDSLD913vXqdK0+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 17, 2020 at 3:44 AM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> Hmm, I should have spoken sooner...
>
> src/backend/replication/walsender.c:static bool TransactionIdInRecentPast(TransactionId xid, uint32 epoch);
> src/backend/utils/adt/xid8funcs.c:TransactionIdInRecentPast(FullTransactionId fxid, TransactionId *extracted_xid)
>
> I don't care much for having two different functions with the same name and related semantics but different argument types.
Maybe that's not ideal, but it's not because of this patch. Those
functions are from 5737c12df05 and 857ee8e391f.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-04-16 17:58:46 | Re: xid wraparound danger due to INDEX_CLEANUP false |
| Previous Message | Andres Freund | 2020-04-16 17:46:01 | Re: fixing old_snapshot_threshold's time->xid mapping |