Re: Potential stack overflow in incremental base backup

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Potential stack overflow in incremental base backup
Date: 2024-03-23 02:27:16
Message-ID: CA+hUKGLe8UB+7KgRhk6f5CiPDsYBY7gfS0=rC73aoXkX5KKtMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 8, 2024 at 6:53 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> But I think that's really only necessary if we're actually going to
> get rid of the idea of segmented relations altogether, which I don't
> think is happening at least for v17, and maybe not ever.

Yeah, I consider the feedback on ext4's size limitations to have
completely killed the idea of getting rid of segments for the
foreseeable future, at least in standard md.c (though who knows what
people will do with pluggable smgr?). As for initdb --rel-segsize (CF
#4305) for md.c, I abandoned plans to do that for 17 because I
couldn't see what to do about this issue. Incremental backup
effectively relies on smaller segments, by using them as
problem-dividing granularity for checksumming and memory usage.
That'll take some research...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-03-23 02:41:41 Re: Large block sizes support in Linux
Previous Message Tom Lane 2024-03-23 02:23:13 Re: Cannot find a working 64-bit integer type on Illumos