Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, rootcause000(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows
Date: 2025-01-08 03:48:03
Message-ID: CA+hUKGLdmvPzEWN_yfAqOPpFDYNXWjiPNTjX2buSHRvW0urnTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Jan 8, 2025 at 4:22 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> It seems to me that you meant to do the following in the back
> branches:

> - return smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
> + smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);

Right, that was accepted by my compiler and apparently almost all the
others, but is not really allowed in C (it's allowed in C++, and
useful for generic forwarding). Duh. Will fix.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Dunstan 2025-01-08 14:45:19 Re: pg_rewind fails on Windows where tablespaces are used
Previous Message Michael Paquier 2025-01-08 03:22:41 Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows