Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "9erthalion6(at)gmail(dot)com" <9erthalion6(at)gmail(dot)com>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid
Date: 2019-05-06 03:30:24
Message-ID: CA+hUKGL__sKNiUTpipNJ+Eajhh2pm3g9NLFiq-LENsCcApTXXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 1, 2019 at 12:57 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Tue, Apr 30, 2019 at 10:47:37PM +1200, Thomas Munro wrote:
> > --- a/src/test/perl/PostgresNode.pm
> > +++ b/src/test/perl/PostgresNode.pm
> > @@ -1098,17 +1098,12 @@ sub get_new_node
> > # native Perl (https://stackoverflow.com/a/14388707)
> > so we also test
> > # individual addresses.
> > #
> > - # This seems like a good idea on Unixen as well, even
> > though we don't
> > - # ask the postmaster to open a TCP port on Unix. On Non-Linux,
> > - # non-Windows kernels, binding to 127.0.0.1/24
> > addresses other than
> > - # 127.0.0.1 fails with EADDRNOTAVAIL.
> > - #
>
> Deleting that comment paragraph isn't quite right, since we're still testing
> 127.0.0.1 everywhere. The paragraph does have cause to change.

Hi Noah,

I put the second sentence back and tweaked it thus: s/fails/might
fail/. Maybe I'm being too pedantic here, but binding to 127.0.0.2
works on other OSes too, as long as you've configured an interface or
alias for it (and it's not terribly uncommon to do so). Here's a
version with a commit message. Please let me know if you want to
tweak the comments further.

--
Thomas Munro
https://enterprisedb.com

Attachment Content-Type Size
0001-Probe-only-127.0.0.1-when-looking-for-ports-on-Unix.patch application/octet-stream 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-06 03:44:47 Re: Fixing order of resowner cleanup in 12, for Windows
Previous Message Thomas Munro 2019-05-06 00:56:46 Re: Fixing order of resowner cleanup in 12, for Windows