| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: O_DIRECT on macOS |
| Date: | 2021-07-13 01:25:50 |
| Message-ID: | CA+hUKGLYTWZ7=y=p=VqwOjqyTnCMa4g46DxkX73Qiuc0U8R3EQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 31, 2021 at 10:29 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> For comparison, here is my sketch of idea #1. I pick an arbitrary
> value to use as PG_O_DIRECT (I don't want to define O_DIRECT for fear
> of breaking other code that might see it and try to pass it into
> open()... for all I know, it might happen to match OS-internal value
> O_NASAL_DEMONS), and statically assert that it doesn't collide with
> standard flags we're using, and I strip it out of the flags I pass in
> to open(). As I said, a bit icky, but it's a tiny and localised
> patch, which is nice.
I'm planning to go with that idea (#1), if there are no objections.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-13 01:36:21 | Re: Is tuplesort meant to support bounded datum sorts? |
| Previous Message | Kyotaro Horiguchi | 2021-07-13 01:22:02 | Re: Fix comments of heap_prune_chain() |