| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
| Date: | 2022-03-07 21:39:06 |
| Message-ID: | CA+hUKGLVMHM2OcJ=u=V8LcF=5JfJtGXn=axfozs8yWyEsvv20A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 8, 2022 at 12:58 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Mar 04, 2022 at 11:26:43PM +1300, Thomas Munro wrote:
> > + /* Skip in-place tablespaces (testing use only) */
> > + if (get_dirent_type(fullpath, de, false, ERROR) == PGFILETYPE_DIR)
> > + continue;
>
> I saw the warning when testing base backups with in-place tablespaces
> and it did not annoy me much, but, yes, that can be confusing.
>
> Junction points are directories, no? Are you sure that this works
> correctly on WIN32? It seems to me that we'd better use readlink()
> only for entries in pg_tlbspc/ that are PGFILETYPE_LNK on non-WIN32
> and pgwin32_is_junction() on WIN32.
Thanks, you're right. Test on a Win10 VM. Here's a new version.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Suppress-pg_basebackup-warning-for-in-place-tablespa.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-03-07 21:43:57 | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
| Previous Message | David G. Johnston | 2022-03-07 21:34:20 | Re: role self-revocation |