Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: James Hilliard <james(dot)hilliard1(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date: 2021-03-31 00:43:15
Message-ID: CA+hUKGLTTeEiQq9of=kDL_r_RT6LdSKCZ4fUX0qjNqFinEzswQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 30, 2021 at 7:39 PM James Hilliard
<james(dot)hilliard1(at)gmail(dot)com> wrote:
> On Mon, Mar 29, 2021 at 11:58 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > We haven't claimed in the past to support MACOSX_DEPLOYMENT_TARGET,
> > and I'm not sure we should start now. How many people actually care
> > about that?
>
> Seems kinda important for anyone who wants to build postgres
> compatible with targets older than the host system.

Personally I'm mostly concerned about making it easy for new
contributors to get a working dev system going on a super common
platform without dealing with hard-to-diagnose errors, than people who
actually want a different target as a deliberate choice. Do I
understand correctly that there a period of time each year when major
upgrades come out of sync and lots of people finish up running a
toolchain and OS with this problem for a while due to the default
target not matching? If so I wonder if other projects are running
into this with AC_REPLACE_FUNCS and what they're doing.

I suppose an alternative strategy would be to try to detect the
mismatch and spit out a friendlier warning, if we decide we're not
going to support such builds.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-03-31 00:44:26 Re: multi-install PostgresNode fails with older postgres versions
Previous Message Mark Dilger 2021-03-31 00:41:56 Re: multi-install PostgresNode fails with older postgres versions