Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

On Wed, May 4, 2022 at 6:36 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Apr 22, 2022 at 3:38 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > So, to summarise the new patch that I'm attaching to this email as 0001:
>
> This all makes sense to me, and I didn't see anything obviously wrong
> looking through the patch, either.

Thanks.

> > However it seems that I have something wrong, because CI is failing on
> > Windows; I ran out of time for looking into that today, but wanted to
> > post what I have so far since I know we have an open item or two to
> > close here ASAP...
>
> :-(

It passes sometimes and fails sometimes. Here's the weird failure I
need to debug:

https://api.cirrus-ci.com/v1/artifact/task/6033765456674816/log/src/test/recovery/tmp_check/log/regress_log_032_relfilenode_reuse

Right at the end, it says:

Warning: unable to close filehandle GEN26 properly: Bad file
descriptor during global destruction.
Warning: unable to close filehandle GEN21 properly: Bad file
descriptor during global destruction.
Warning: unable to close filehandle GEN6 properly: Bad file descriptor
during global destruction.

I don't know what it means (Windows' fd->handle mapping table got
corrupted?) or even which program is printing it (you'd think maybe
perl? but how could that be affected by anything I did in
postgres.exe, but if it's not perl why is it always at the end like
that?). Hrmph.