Re: Remove trailing comma from enums

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove trailing comma from enums
Date: 2022-01-06 01:10:59
Message-ID: CA+hUKGLQVaLUT69Ai6WOCZiU1r_DZjvYJyet2z36EHDqYocLfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 6, 2022 at 12:56 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> I saw one (and then went looking and found some more) enum with a
> trailing comma.
>
> These are quite rare in the PG src, so I doubt they are intentional.
>
> PSA a patch to remove the trailing commas for all that I found.

-1. I don't see the problem with C99 trailing commas. They avoid
noisy diff lines when patches add/remove items.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-01-06 01:18:11 Re: Proposal: remove obsolete hot-standby testing infrastructure
Previous Message Justin Pryzby 2022-01-06 00:57:48 Re: make tuplestore helper function