Re: ci: Allow running mingw tests by default via environment variable

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Wolfgang Walther <walther(at)technowledgy(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(at)vondra(dot)me>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: ci: Allow running mingw tests by default via environment variable
Date: 2025-04-12 08:18:35
Message-ID: CA+hUKGLPQSSS-+h4gjJO6SPcWiVUHWEdMRAwnjOMDQD57AW-Vg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 8, 2025 at 1:43 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2025-04-07 16:03:48 +0300, Nazir Bilal Yavuz wrote:
> > On Wed, 5 Mar 2025 at 18:51, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > I'm inclined to think we should apply to this to all branches with CI support,
> > > not just master. It's kind of annoying to have CI infrastructure changes like
> > > this that differ between branches. Thoughts?
> >
> > I am sharing patches per branch until we come up with a better
> > solution. Some remarks:
> >
> > REL_15: It doesn't have any manual tasks, so per repository trigger
> > patch (Thomas' patch) is omitted.
> > REL_16: Only Mingw task is manual.
> > REL_17: Only Mingw task is manual.
> >
> > While rebasing them, I realized that we use
> > 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' for all branches. So, we don't have
> > per branch 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' configuration option. Is
> > that a problem?
>
> I think that's not a problem. I can't think of a case where one would want to
> do this only for some of the branches. Does anybody disagree?

Nope.

I think we should push all this stuff and turn it on for cfbot, not
only for the benefit of new development but also for the v18
stabilisation period.

Is it safe to assume that CI changes come under the same code-freeze
exception as tests and docs? I would assume so, it's just scripting
glue in .cirrus.XXX files not affecting one bit of the software, but I
don't recall that we specifically clarified that before, so can
someone from the RMT please +1 this? Then I'll go ahead and push
these.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2025-04-12 08:29:42 Re: Can we use Statistics Import and Export feature to perforamance testing?
Previous Message Michael Paquier 2025-04-12 04:26:36 Re: stats.sql fails during installcheck on mac