Re: Wait events for delayed checkpoints

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wait events for delayed checkpoints
Date: 2023-10-13 03:51:50
Message-ID: CA+hUKGLHR69zfR0dYmtcy78b1Aibck0km=6Ns284i2i+2Qf5Rw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 13, 2023 at 2:19 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Oct 12, 2023 at 7:09 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > HaveVirtualXIDsDelayingChkpt() does immediately a LWLockAcquire()
> > which would itself report a wait event for ProcArrayLock, overwriting
> > this new one, no?
>
> Ah, right: the wait event should be set and cleared around pg_usleep,
> not the whole loop.

Duh. Yeah. Pushed like that. Thanks both.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-10-13 03:59:25 Re: pg_upgrade's interaction with pg_resetwal seems confusing
Previous Message Peter Smith 2023-10-13 03:32:52 Re: PGDOCS - add more links in the pub/sub reference pages