Re: CI, macports, darwin version problems

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Christophe Pettus <christophe(dot)pettus(at)pgexperts(dot)com>, Joe Conway <mail(at)joeconway(dot)com>
Subject: Re: CI, macports, darwin version problems
Date: 2024-07-16 03:19:06
Message-ID: CA+hUKGLCBBL=nX5ABDmiWmaDNgELkNSDZH3Xy2jMpbVNQYWu8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 16, 2024 at 10:48 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> WRT your patches:
> - I think we ought to switch to the -runner image, otherwise we'll just
> continue to get that "upgraded" warning

Right, let's try it.

> - With a fingerprint_script specified, we need to add
> reupload_on_changes: true
> otherwise it'll not be updated.

Ahh, I see.

> - I think the fingerprint_script should use sw_vers, just as the script
> does. I see no reason to differ?

Yeah might as well. I started with Darwin versions because that is
what MacPorts complains about, but they move in lockstep.

> - We could just sw_vers -productVersion | sed 's/\..*//g' instead of the more
> complicated version you used, I doubt that they're going to go away from
> numerical major versions...

Yep.

I've attached a new version like that. Let's see which runner machine
gets it and how it turns out...

Attachment Content-Type Size
v4-0001-ci-Upgrade-macOS-version-from-13-to-14.patch text/x-patch 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-07-16 03:59:46 Re: long-standing data loss bug in initial sync of logical replication
Previous Message Noah Misch 2024-07-16 01:52:26 Re: Confine vacuum skip logic to lazy_scan_skip