Re: On non-Windows, hard depend on uselocale(3)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tristan Partin <tristan(at)partin(dot)io>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
Date: 2024-08-15 08:49:11
Message-ID: CA+hUKGL9aZ4mn0OMR-D=5+qpdxOsO_tGyOQhK2nW1raTemAFAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 14, 2024 at 11:17 AM Tristan Partin <tristan(at)partin(dot)io> wrote:
> Thanks for picking this up. I think your patch looks really good.

Thanks for looking!

> Are
> you familiar with gcc's function poisoning?
>
> #include <stdio.h>
> #pragma GCC poison puts
>
> int main(){
> #pragma GCC bless begin puts
> puts("a");
> #pragma GCC bless end puts
> }
>
> I wonder if we could use function poisoning to our advantage. For
> instance in ecpg, it looks like you got all of the strtod() invocations
> and replaced them with strtod_l(). Here is a patch with an example of
> what I'm talking about.

Thanks, this looks very useful.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2024-08-15 08:49:36 Re: Vacuum statistics
Previous Message Thomas Munro 2024-08-15 08:46:15 Re: Remaining dependency on setlocale()