| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A micro-optimisation for walkdir() |
| Date: | 2020-09-03 06:38:07 |
| Message-ID: | CA+hUKGL4a+dos9p+SopNRRmX2AfryWHDbLrXxx8r-sRgzhD-ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 3, 2020 at 5:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> [request for better comments]
Ack.
> Both of these concerns would abate if we had get_dirent_type()
> just throw an error itself when stat() fails, thereby removing the
> PGFILETYPE_ERROR result code. I'm not 100% sold either way on
> that, but it's something to think about. Is there ever going
> to be a reason for the caller to ignore an error?
Hmm. Well I had it like that in an earlier version, but then I
couldn't figure out the right way to write code that would work in
both frontend and backend code, without writing two copies in two
translation units, or putting the whole thing in a header. What
approach do you prefer?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2020-09-03 06:38:57 | Re: Get memory contexts of an arbitrary backend process |
| Previous Message | Tom Lane | 2020-09-03 05:40:03 | Re: Fix for configure error in 9.5/9.6 on macOS 11.0 Big Sur |