Re: On non-Windows, hard depend on uselocale(3)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tristan Partin <tristan(at)neon(dot)tech>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
Date: 2024-11-14 01:54:06
Message-ID: CA+hUKGKwyRWONAkHURQJSSW3g8XeXrb-JU=PXq=AiPNGmaeQ9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 2, 2024 at 1:04 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 28.08.24 20:50, Peter Eisentraut wrote:
> > I suggest that the simplification of the xlocale.h configure tests could
> > be committed separately. This would also be useful independent of this,
> > and it's a sizeable chunk of this patch.
>
> To keep this moving along a bit, I have extracted this part and
> committed it separately. I had to make a few small tweaks, e.g., there
> was no check for xlocale.h in configure.ac, and the old
> xlocale.h-including stanza could be removed from chklocale.h. Let's see
> how this goes.

Thanks, Peter. That seemed to work fine, and we shouldn't have to
think about xlocale.h as a special case too much again.

I am back to working on all these cleanup patches. Here is a rebase
of this one, with a few minor style adjustments and a new attempt to
explain the overall approach in the commit message.

Attachment Content-Type Size
v5-0001-Tidy-up-locale-thread-safety-in-ECPG-library.patch text/x-patch 24.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-11-14 02:00:11 Converting SetOp to read its two inputs separately
Previous Message Masahiko Sawada 2024-11-14 01:37:40 Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4