Re: [HACKERS] Cached plans and statement generalization

On Tue, Jul 2, 2019 at 3:29 AM Konstantin Knizhnik
<k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
> Attached please find rebased version of the patch.
> Also this version can be found in autoprepare branch of this repository
> https://github.com/postgrespro/postgresql.builtin_pool.git
> on github.

Thanks. I haven't looked at the code but this seems like interesting
work and I hope it will get some review. I guess this is bound to use
a lot of memory. I guess we'd eventually want to figure out how to
share the autoprepared plan cache between sessions, which is obviously
a whole can of worms.

A couple of trivial comments with my CF manager hat on:

1. Can you please fix the documentation? It doesn't build.
Obviously reviewing the goals, design and implementation are more
important than the documentation at this point, but if that is fixed
then the CF bot will be able to run check-world every day and we might
learn something about the code.
2. Accidental editor junk included: src/include/catalog/pg_proc.dat.~1~

--
Thomas Munro
https://enterprisedb.com