| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
| Date: | 2023-03-07 02:44:46 |
| Message-ID: | CA+hUKGKtii2y4RgdQn6UPyyjLw6+jfbx_TRR5NUqBCdZWcEGhA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 7, 2023 at 3:42 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Apparently ye olde GCC 4.7 on "lapwing" doesn't like the way you
> initialised that struct. I guess it wants {{0}} instead of {0}.
> Apparently old GCC was wrong about that warning[1], but that system
> doesn't have the back-patched fixes? Not sure.
Oh, you already pushed a fix. But now I'm wondering if it's useful to
have old buggy compilers set to run with -Werror.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2023-03-07 02:47:09 | Re: proposal: possibility to read dumped table's name from file |
| Previous Message | Thomas Munro | 2023-03-07 02:42:03 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |