From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Subject: | Re: Regression tests vs SERIALIZABLE |
Date: | 2021-03-17 04:28:28 |
Message-ID: | CA+hUKGKjOpH1gTqgQsbEYbHR9e+=kcJecd=jOspuHWR7BeBvDQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 16, 2021 at 3:28 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> >> However, since commit 862ef372d6b, there *is* one test that fails if
> >> you run make installcheck against a cluster running with -c
> >> default_transaction_isolation=serializable: transaction.sql. Is that
> >> a mistake? Is it a goal to be able to run this test suite against all
> >> 3 isolation levels?
>
> > Here's a fix.
>
> Usually, if we issue a SET in the regression tests, we explicitly RESET
> as soon thereafter as practical, so as to have a well-defined scope
> where the script is running under unusual conditions.
Oh, of course. Thanks.
I was wrong to blame that commit, and there are many other tests that
fail in the back branches. But since we were down to just one, I went
ahead and fixed this in the master branch only.
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2021-03-17 04:30:30 | Re: pl/pgsql feature request: shorthand for argument and local variable references |
Previous Message | Tom Lane | 2021-03-17 04:01:55 | Re: Getting better results from valgrind leak tracking |