| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Mats Kindahl <mats(at)timescale(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jakub(dot)wartak(at)enterprisedb(dot)com |
| Subject: | Re: Use streaming read API in ANALYZE |
| Date: | 2024-08-24 03:33:19 |
| Message-ID: | CA+hUKGKiuv86r_N3gykwB11J-q=gLXQzpGOw10x-jnmMH68RgA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 22, 2024 at 7:31 PM Mats Kindahl <mats(at)timescale(dot)com> wrote:
> The alternate version proposed by Nazir allows you to decide which interface to use.
> Reverting the patch entirely would also solve the problem.
> Passing down the block sampler and the strategy to scan_begin() and move the ReadStream setup in analyze.c into initscan() in heapam.c, but this requires adding new parameters to this function.
> Having accessors that allow you to get the block sampler and strategy from the ReadStream object.
I'm a bit confused about how it can make sense to use the same
BlockSampler with a side relation/fork. Could you point me at the
code?
> It would be great if this could be fixed before the PG17 release now that 27bc1772fc8 was reverted.
Ack. Thinking...
Random thought: is there a wiki page or something where we can find
out about all the table AM projects? For the successor to
27bc1772fc8, I hope they'll be following along.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-08-24 04:00:00 | Re: DELETE PENDING strikes back, via pg_ctl stop/start |
| Previous Message | shawn wang | 2024-08-24 02:42:04 | Re: Trim the heap free memory |