| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix tablespace handling in pg_combinebackup |
| Date: | 2024-04-22 21:15:27 |
| Message-ID: | CA+hUKGKi71FwK3W_O=PMMyeKxd6CSAoL=33cCuScL-P737VDjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 23, 2024 at 8:05 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I reworked the test cases so that they don't (I think) rely on
> symlinks working as they do on normal platforms.
Cool.
(It will remain a mystery for now why perl readlink() can't read the
junction points that PostgreSQL creates (IIUC), but the OS can follow
them and PostgreSQL itself can read them with apparently similar code.
I find myself wondering if symlinks should go on the list of "things
we pretended Windows had out of convenience, that turned out to be
more inconvenient than we expected, and we'd do better to tackle
head-on with a more portable idea". Perhaps we could just use a
tablespace map file instead to do our own path construction, or
something like that. I suspect that would be one of those changes
that is technically easy, but community-wise hard as it affects a
load of backup tools and procedures...)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2024-04-22 21:19:44 | Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs |
| Previous Message | Daniel Gustafsson | 2024-04-22 21:09:42 | Re: DROP OWNED BY fails to clean out pg_init_privs grants |