| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EINTR in ftruncate() |
| Date: | 2022-07-14 12:15:22 |
| Message-ID: | CA+hUKGKfH8kfF_SUqAxxxOTX=EvwdgJx61d89Hj--mKnhOjGEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 12, 2022 at 5:45 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hm - given that we've observed ftruncate failing with strace, and that
> stracing to find problems isn't insane, shouldn't we retry the ftruncate too?
> It's kind of obsoleted by your next patch, but not really, because it's not
> unconceivable that other OSs behave similarly? And IIUC you're planning to not
> backpatch 0002?
Yeah. Done, and pushed. 0002 not back-patched.
> > + pgstat_report_wait_start(WAIT_EVENT_DSM_FILL_ZERO_WRITE);
>
> (not new in this patch, just moved around) - FILL_ZERO_WRITE is imo an odd
> description of what's happening... In my understanding this isn't doing any
> writing, just allocating. But whatever...
True. Fixed in master.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Geier | 2022-07-14 12:45:29 | Re: Lazy JIT IR code generation to increase JIT speed with partitions |
| Previous Message | Thomas Munro | 2022-07-14 12:11:15 | Re: Fix gcc warning in sync.c (usr/src/backend/storage/sync/sync.c) |