Re: A failure in 031_recovery_conflict.pl on Debian/s390x

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Christoph Berg <myon(at)debian(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: A failure in 031_recovery_conflict.pl on Debian/s390x
Date: 2023-09-07 03:39:31
Message-ID: CA+hUKGK_bSq+pU=UKvDrSM-E6eAMbc_8CNPde48qXys7Boyb_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 8, 2023 at 11:08 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2023-08-07 12:57:40 +0200, Christoph Berg wrote:
> > v8 worked better. It succeeded a few times (at least 12, my screen
> > scrollback didn't catch more) before erroring like this:
>
> > [10:21:58.410](0.151s) ok 15 - startup deadlock: logfile contains terminated connection due to recovery conflict
> > [10:21:58.463](0.053s) not ok 16 - startup deadlock: stats show conflict on standby
> > [10:21:58.463](0.000s)
> > [10:21:58.463](0.000s) # Failed test 'startup deadlock: stats show conflict on standby'
> > # at t/031_recovery_conflict.pl line 332.
> > [10:21:58.463](0.000s) # got: '0'
> > # expected: '1'
>
> Hm, that could just be a "harmless" race. Does it still happen if you apply
> the attached patch in addition?

Do you intend that as the fix, or just proof of what's wrong? It
looks pretty reasonable to me. I will go ahead and commit this unless
you want to change something/do it yourself. As far as I know so far,
this is the last thing preventing the mighty Debian/s390x build box
from passing consistently, which would be nice.

Attachment Content-Type Size
0001-Update-recovery-conflict-stats-immediately.patch text/x-patch 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-07 04:23:33 Re: pg_basebackup: Always return valid temporary slot names
Previous Message shveta malik 2023-09-07 02:59:14 Re: Synchronizing slots from primary to standby