Re: [HACKERS] make async slave to wait for lsn to be replayed
From:
Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To:
Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc:
Kartyshov Ivan <i(dot)kartyshov(at)postgrespro(dot)ru>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, dilipbalaut(at)gmail(dot)com, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject:
Re: [HACKERS] make async slave to wait for lsn to be replayed
I didn't review the patch but one thing jumped out: I don't think it's OK to hold a spinlock while (1) looping over an array of backends and (2) making system calls (SetLatch()).