| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Extending SMgrRelation lifetimes |
| Date: | 2024-01-31 08:54:58 |
| Message-ID: | CA+hUKGKVQLV9yC_LT=NcXwXNc5hXM7ad93q4z+-gO-uVQgGthQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2023 at 1:42 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> I spent some more time digging into this, experimenting with different
> approaches. Came up with pretty significant changes; see below:
Hi Heikki,
I think this approach is good. As I wrote in the first email, I had
briefly considered reference counting, but at the time I figured there
wasn't much point if it's only ever going to be 0 or 1, so I was
trying to find the smallest change. But as you explained, there is
already an interesting case where it goes to 2, and modelling it that
way removes a weird hack, so it's a net improvement over the unusual
'owner' concept. +1 for your version. Are there any further tidying
or other improvements you want to make?
Typos in comments:
s/desroyed/destroyed/
s/receiveing/receiving/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-01-31 09:00:00 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |
| Previous Message | Alvaro Herrera | 2024-01-31 08:48:00 | Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix |