Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions
Date: 2023-08-18 10:25:23
Message-ID: CA+hUKGKV-ND5r7fQYnWbVBxC1s6iCaSzwknYgR2kAfMJGuxWbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Aug 18, 2023 at 12:48 AM John Naylor
<john(dot)naylor(at)enterprisedb(dot)com> wrote:
> On Thu, Aug 17, 2023 at 11:41 AM John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> > On Wed, Aug 16, 2023 at 5:17 PM John Naylor <john(dot)naylor(at)postgresql(dot)org> wrote:
> > >
> > > Split out tiebreaker comparisons from comparetup_* functions
> >
> > Hammerkop is getting OOM errors with this change. Most grand totals in the memory context stats show between 1 and 3 MB, and "tuplesort main" only shows small-ish requests, so not sure what's going on.
>
> That remains the only new failure in the buildfarm, and it just failed in the same way again. I'll try to figure out what could be the cause, but if I don't I'll revert within 24 hours.

I don't know what's going on on that machine but those two failures
seem different, and there are also now some failures in release
branches that don't have your commit, so I'd wait long for more
evidence...

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2023-08-18 10:57:09 Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions
Previous Message Peter Eisentraut 2023-08-18 05:58:41 pgsql: Remove dubious warning message from SQL/JSON functions