| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: race condition when writing pg_control |
| Date: | 2020-06-08 02:48:55 |
| Message-ID: | CA+hUKGKToqjdeRtr8ZHVbPToShun5ifjioj6x3nsjseOkhCMEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 3, 2020 at 2:03 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jun 03, 2020 at 10:56:13AM +1200, Thomas Munro wrote:
> > Sorry for my radio silence, I got tangled up with a couple of
> > conferences. I'm planning to look at 0001 and 0002 shortly.
>
> Thanks!
I pushed 0001 and 0002, squashed into one commit. I'm not sure about
0003. If we're going to do that, wouldn't it be better to just
acquire the lock in that one extra place in StartupXLOG(), rather than
introducing the extra parameter?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2020-06-08 03:25:31 | Re: race condition when writing pg_control |
| Previous Message | Michael Paquier | 2020-06-08 01:17:06 | Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762 |