Re: FW: query pg_stat_ssl hang 100%cpu

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: "James Pang (chaolpan)" <chaolpan(at)cisco(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: FW: query pg_stat_ssl hang 100%cpu
Date: 2023-09-07 23:45:51
Message-ID: CA+hUKGKSQEewukGjw6o2FJeN9mkO29pCzmeXHnuPms=VXtjyuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-performance

On Thu, Sep 7, 2023 at 10:59 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Sep 7, 2023 at 10:39 PM James Pang (chaolpan)
> <chaolpan(at)cisco(dot)com> wrote:
> > (gdb) p RecordCacheArray
> > $1 = (TupleDesc *) 0x7f5fac365d90
> > (gdb) p RecordIdentifierArray
> > $2 = (uint64 *) 0x0
>
> Hah, yeah that's it, and you've been extremely unlucky to hit it.
> ensure_record_cache_typmod_slot_exists() should be more careful about
> cleaning up on allocation failure, to avoid this state.

I think the lazy fix would be to re-order those allocations. A
marginally more elegant fix would be to merge the arrays, as in the
attached. Thoughts?

Attachment Content-Type Size
0001-Fix-exception-safety-bug-in-typcache.c.patch text/x-patch 5.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2023-09-08 00:26:01 BUG #18096: In edge-triggered epoll and kqueue, PQconsumeInput/PQisBusy are insufficient for correct async ops.
Previous Message Laurenz Albe 2023-09-07 20:50:36 Re: BUG #18095: Unintended non-SSL connection attempt by psql cli command after a failed password authentication

Browse pgsql-performance by date

  From Date Subject
Next Message Michael Paquier 2023-09-08 02:48:28 Re: FW: query pg_stat_ssl hang 100%cpu
Previous Message Thomas Munro 2023-09-07 10:59:14 Re: FW: query pg_stat_ssl hang 100%cpu