| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2024-07-24 05:40:12 |
| Message-ID: | CA+hUKGKN3oy0bN_3yv8hd78a4+M1tJC9z7mD8+f+yA+GeoFUwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 16, 2024 at 1:52 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Mon, Jul 15, 2024 at 03:26:32PM +1200, Thomas Munro wrote:
> That's reasonable. radixtree already forbids mutations concurrent with
> iteration, so there's no new concurrency hazard. One alternative is
> per_buffer_data big enough for MaxOffsetNumber, but that might thrash caches
> measurably. That patch is good to go apart from these trivialities:
Thanks! I have pushed that patch, without those changes you didn't like.
Here's are Melanie's patches again. They work, and the WAL flush
frequency problem is mostly gone since we increased the BAS_VACUUM
default ring size (commit 98f320eb), but I'm still looking into how
this read-ahead and the write-behind generated by vacuum (using
patches not yet posted) should interact with each other and the ring
system, and bouncing ideas around about that with my colleagues. More
on that soon, hopefully. I suspect that there won't be changes to
these patches as a result, but I still want to hold off for a bit.
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Use-streaming-I-O-in-VACUUM-first-pass.patch | text/x-patch | 8.3 KB |
| v12-0002-Use-streaming-I-O-in-VACUUM-second-pass.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-07-24 05:44:16 | Re: tls 1.3: sending multiple tickets |
| Previous Message | Michael Paquier | 2024-07-24 05:07:21 | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |