Re: Why is citext/regress failing on hamerkop?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why is citext/regress failing on hamerkop?
Date: 2024-05-15 21:46:41
Message-ID: CA+hUKGKH2Zz=sOhsrN9vnZSEE0V0hZjrsFEjxkdoA9jLn2CcFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 15, 2024 at 6:00 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> 15.05.2024 01:26, Thomas Munro wrote:
> > OK, so we know what the problem is here. Here is the simplest
> > solution I know of for that problem. I have proposed this in the past
> > and received negative feedback because it's a really gross hack. But
> > I don't personally know what else to do about the back-branches (or
> > even if that complex solution is the right way forward for master).
> > The attached kludge at least has the [de]merit of being a mirror image
> > of the kludge that follows it for the "opposite" event. Does this fix
> > it?
>
> Yes, I see that abandoned GSS connections are closed immediately, as
> expected. I have also confirmed that `meson test` with the basic
> configuration passes on REL_16_STABLE. So from the outside, the fix
> looks good to me.

Alright, unless anyone has an objection or ideas for improvements, I'm
going to go ahead and back-patch this slightly tidied up version
everywhere.

Attachment Content-Type Size
v2-0001-Add-kludge-to-make-FD_CLOSE-level-triggered.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-05-15 22:03:19 Re: Introduce new multi insert Table AM and improve performance of various SQL commands with it for Heap AM
Previous Message Tom Lane 2024-05-15 21:24:53 Re: Adding the extension name to EData / log_line_prefix