Re: Use streaming read API in ANALYZE

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Mats Kindahl <mats(at)timescale(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jakub(dot)wartak(at)enterprisedb(dot)com
Subject: Re: Use streaming read API in ANALYZE
Date: 2024-09-04 23:34:21
Message-ID: CA+hUKGKFc21z+BasYZJMGo6frhjJnz19CZMDrq=SYvK1LMBVTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 5, 2024 at 3:36 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 4, 2024 at 6:38 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Thanks for the explanation. I think we should revert it. IMHO it was
> > a nice clean example of a streaming transformation, but unfortunately
> > it transformed an API that nobody liked in the first place, and broke
> > some weird and wonderful workarounds. Let's try again in 18.
>
> The problem I have with this is that we just released RC1. I suppose
> if we have to make this change it's better to do it sooner than later,
> but are we sure we want to whack this around this close to final
> release?

I hear you. But I definitely don't want to (and likely can't at this
point) make any of the other proposed changes, and I also don't want
to break Timescale. That seems to leave only one option: go back to
the v16 API for RC2, and hope that the ongoing table AM discussions
for v18 (CF #4866) will fix all the problems for the people whose TAMs
don't quack like a "heap", and the people whose TAMs do and who would
not like to duplicate the code, and the people who want streaming I/O.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-09-04 23:58:29 Re: Avoid overflowed array index (src/backend/utils/activity/pgstat.c)
Previous Message Jehan-Guillaume de Rorthais 2024-09-04 22:57:28 Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails