Re: Cleaning up historical portability baggage

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up historical portability baggage
Date: 2022-08-15 05:53:04
Message-ID: CA+hUKGKErNfhmvb_H0UprEmp4LPzGN06yR2_0tYikjzB-2ECMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 14, 2022 at 10:03 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> All green on CI... Next stop, build farm.

All good so far (except for an admonishment from crake, for which my
penance was to fix headerscheck, see separate thread...). I did
figure out one thing that I mentioned I was confused by before: the
reason Windows didn't like my direct calls to gai_strerror() is
because another header of ours clobbered one of Windows' own macros.
This new batch includes a fix for that.

Remove configure probe for IPv6.
Remove dead ifaddrs.c fallback code.
Remove configure probe for net/if.h.
Fix macro problem with gai_strerror on Windows.
Remove configure probe for netinet/tcp.h.
mstcpip.h is not missing on MinGW.

The interesting one is a continuation of my "all computers have X"
series. This episode: IPv6.

Attachment Content-Type Size
0001-Remove-configure-probe-for-IPv6.patch text/x-patch 15.8 KB
0002-Remove-dead-ifaddr.c-fallback-code.patch text/x-patch 3.9 KB
0003-Remove-configure-probe-for-net-if.h.patch text/x-patch 3.1 KB
0004-Fix-macro-problem-with-gai_strerror-on-Windows.patch text/x-patch 1.4 KB
0005-Remove-configure-probe-for-netinet-tcp.h.patch text/x-patch 7.2 KB
0006-mstcpip.h-is-not-missing-on-MinGW.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-08-15 06:00:49 Re: Assertion failure in WaitForWALToBecomeAvailable state machine
Previous Message Masahiko Sawada 2022-08-15 05:38:29 Re: [PoC] Improve dead tuple storage for lazy vacuum