| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Kyle Kingsbury <aphyr(at)jepsen(dot)io> |
| Subject: | Re: Potential G2-item cycles under serializable isolation |
| Date: | 2020-06-09 02:00:58 |
| Message-ID: | CA+hUKGK8xPpi-vQLO0ecGgB7Lm5qe2Ps8GS5RjJk79nnO4jVKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jun 9, 2020 at 1:26 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> The functionality in question (the code from the
> HeapCheckForSerializableConflictOut() case statement) was originally
> discussed here, with the details finalized less than a week before SSI
> was committed in 2011:
>
> https://www.postgresql.org/message-id/flat/1296499247.11513.777.camel%40jdavis#9e407424df5f8794360b6e84de60200a
>
> It hasn't really changed since that time.
Right, the only change was to move things around a bit to suport new
table AMs. Speaking of which, it looks like the new comment atop
CheckForSerializableConflictOut() could use some adjustment. It says
"A table AM is reading a tuple that has been modified. After
determining that it is visible to us, it should call this function..."
but it seems the truth is a bit more complicated than that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-06-09 02:07:46 | Re: Potential G2-item cycles under serializable isolation |
| Previous Message | Tom Lane | 2020-06-09 01:59:18 | Re: BUG #16486: Prompted password is ignored when password specified in connection string |