Re: pgsql: Handle lack of DSM slots in parallel btree build.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Handle lack of DSM slots in parallel btree build.
Date: 2020-02-04 23:37:28
Message-ID: CA+hUKGK1teTDFxc8SbQOgXN6rMNmC2TLwg=KXL0YGuM=gfw3AQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Feb 5, 2020 at 6:47 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Tue, Feb 4, 2020 at 9:42 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Can we reuse _bt_end_parallel() this time around? It would be easy to
> > add a "bool wait" argument to _bt_end_parallel(). All existing callers
> > would pass true, but when not using parallelism due to the new DSM
> > segment check we'd pass false.
>
> Hmm. I see why you didn't do it that way -- we don't quite have the
> variables set up in the way that _bt_end_parallel() expects them.
>
> This looks good, then.

Thanks. Pushed.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-02-05 01:46:05 Re: pgsql: Handle lack of DSM slots in parallel btree build.
Previous Message Thomas Munro 2020-02-04 23:36:28 pgsql: Handle lack of DSM slots in parallel btree build, take 2.