Re: extension patch of CREATE OR REPLACE TRIGGER

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extension patch of CREATE OR REPLACE TRIGGER
Date: 2019-08-01 09:49:53
Message-ID: CA+hUKGJwY8qgiGk4kEmYCkF0HLOr2kXnDem6_Kkq=gNA1oPpsA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 31, 2019 at 1:33 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 30, 2019 at 04:44:11PM -0400, Tom Lane wrote:
> > We do not test \h output in any existing regression test, and we're
> > not going to start doing so in this one. For one thing, the expected
> > URL would break every time we forked off a new release branch.
> > (There would surely be value in having more-than-no test coverage
> > of psql/help.c, but that's a matter for its own patch, which would
> > need some thought about how to cope with instability of the output.)
>
> One way to get out of that could be some psql-level options to control
> which parts of the help output is showing up. The recent addition of
> the URL may bring more weight for doing something in this area.

Hello again Osumi-san,

The end of CF1 is here. I've moved this patch to CF2 (September) in
the Commitfest app. Of course, everyone is free to continue
discussing the patch before then. When you have a new version, please
set the status to "Needs review".

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-08-01 09:53:37 Re: Proposal for Signal Detection Refactoring
Previous Message Adrien Nayrat 2019-08-01 09:47:46 Re: idea: log_statement_sample_rate - bottom limit for sampling