Re: Tree-walker callbacks vs -Wdeprecated-non-prototype

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Date: 2022-12-12 02:45:51
Message-ID: CA+hUKGJvX+L3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As visible on seawasp and locally (16/main branch nightly packages),
they decided to start warning about these casts with a new strict
variant of the warning. Their discussion:

https://reviews.llvm.org/D134831

There are also a few other cases unrelated to this thread's original
problem, for example casts involving pg_funcptr_t, HashCompareFunc. I
guess our options would be to turn that warning off, or reconsider and
try shoving the cast of "generic" arguments pointers down into the
functions?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-12-12 02:57:17 Re: Improve WALRead() to suck data directly from WAL buffers when possible
Previous Message Peter Geoghegan 2022-12-12 02:00:40 Re: Why does L&Y Blink Tree need lock coupling?