Re: Direct I/O

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Christoph Berg <myon(at)debian(dot)org>, mikael(dot)kjellstrom(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Direct I/O
Date: 2023-08-23 04:57:43
Message-ID: CA+hUKGJtDN4Z2S_zJwHC0S4cyK_xF8WA1_ANp_mpTq6RH-rhyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 23, 2023 at 12:15 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> I suggest to also rename the hook functions (check and assign), like in
> the attached patch. Mainly because utils/guc_hooks.h says to order the
> functions by GUC variable name, which was already wrong under the old
> name, but it would be pretty confusing to sort the functions by their
> GUC name that doesn't match the function names.

OK. I'll push this tomorrow unless you do it while I'm asleep. Thanks!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-08-23 05:10:13 RE: persist logical slots to disk during shutdown checkpoint
Previous Message Thomas Munro 2023-08-23 04:54:49 Re: Extending SMgrRelation lifetimes