| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: An out-of-date comment in nodeIndexonlyscan.c |
| Date: | 2021-06-13 22:03:08 |
| Message-ID: | CA+hUKGJomqEBnY_-c6Uk=ogWFipiML=+nEB3CALB4zM+OKm4zQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 14, 2021 at 12:54 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I think a more optimal and nicer way of doing that would be setting
> bits in a Bitmapset then checking bms_num_members is equal to
> n_scan_keys.
Shouldn't it be compared with indnkeyatts? Yes, much nicer, thanks!
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Use-tuple-level-SIREAD-locks-for-index-only-scans.patch | text/x-patch | 6.7 KB |
| v3-0002-WIP-Skip-SIREAD-locks-on-btree-pages-when-possibl.patch | text/x-patch | 32.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-13 22:09:20 | Re: Continuing instability in insert-conflict-specconflict test |
| Previous Message | Noah Misch | 2021-06-13 21:29:43 | Re: Continuing instability in insert-conflict-specconflict test |