| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cannot find a working 64-bit integer type on Illumos |
| Date: | 2024-12-04 22:45:50 |
| Message-ID: | CA+hUKGJj71+xFnEF8D26MMYiATNSECdi=3tcpm1kncpmLDJd7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 5, 2024 at 10:58 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Dec 5, 2024 at 10:55 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Could another way be to read pg_config.h before postgres_ext.h?
> > I think the current order was intentional, but maybe the
> > disadvantages outweigh the advantages now.
>
> Yeah I was just testing that idea :-) I can't see why it needs to be
> first, but was looking for what the original reason was...
Seems good to me. Also there were another couple of contortions due
to the older ordering, which we could improve I think?
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-header-inclusion-order-in-c.h.patch | text/x-patch | 1.4 KB |
| 0002-Add-required-headers-to-postgres_ext.h.patch | text/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-12-04 22:52:01 | Re: Make tuple deformation faster |
| Previous Message | Jacob Champion | 2024-12-04 22:11:31 | Re: SCRAM pass-through authentication for postgres_fdw |