Re: Mingw task for Cirrus CI

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Mingw task for Cirrus CI
Date: 2022-08-04 08:38:34
Message-ID: CA+hUKGJfYqLEap0a4Ct-LKJFP-jRUT1iOQEDdfPvnTo2wp_jkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 4, 2022 at 2:04 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I noticed that this says:
>
> [01:01:45.657] sqlda.pgc: In function 'dump_sqlda':
> [01:01:45.657] sqlda.pgc:45:33: warning: format '%d' expects argument
> of type 'int', but argument 3 has type 'long long int' [-Wformat=]
> [01:01:45.657] 45 | "name sqlda descriptor: '%s' value %I64d\n",
> [01:01:45.657] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [01:01:45.657] ......
> [01:01:45.657] 49 | sqlda->sqlvar[i].sqlname.data, *(long long int
> *)sqlda->sqlvar[i].sqldata);
> [01:01:45.657] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [01:01:45.657] | |
> [01:01:45.657] | long long int
>
> ... but fairywren doesn't. Why would they disagree on recognising %I64d?

Oops, I was looking in the wrong place. fairywren does also shows the warning:

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=fairywren&dt=2022-08-02%2022%3A05%3A30&stg=ecpg-check

Something to fix, but not directly relevant to this patch. Sorry for the noise.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marco Slot 2022-08-04 08:56:45 Re: How is this possible "publication does not exist"
Previous Message Michael Paquier 2022-08-04 08:38:00 Re: Fix obsoleted comments for function prototypes