Re: wake up logical workers after ALTER SUBSCRIPTION

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: 2022-11-22 02:16:05
Message-ID: CA+hUKGJe50UztHqCrXsXMK_VkDvXNnxWfRo28XGN8YbWCeT-Zg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 22, 2022 at 1:41 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> On my machine, the attached patch
> improved 'check-world -j8' run time by ~12 seconds (from 3min 8sec to 2min
> 56 sec) and src/test/subscription test time by ~17 seconds (from 139
> seconds to 122 seconds).

Nice!

Maybe a comment to explain why a single variable is enough? And an
assertion that it wasn't already set? And a note to future self: this
would be a candidate user of the nearby SetLatches() patch (which is
about moving SetLatch() syscalls out from under LWLocks, though this
one may not be very hot).

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2022-11-22 02:38:58 Re: Add 64-bit XIDs into PostgreSQL 15
Previous Message houzj.fnst@fujitsu.com 2022-11-22 02:00:05 RE: Perform streaming logical transactions by background workers and parallel apply