Re: Dereference before NULL check (src/backend/storage/ipc/latch.c)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Dereference before NULL check (src/backend/storage/ipc/latch.c)
Date: 2020-11-25 05:00:06
Message-ID: CA+hUKGJPp7Mxt7gCmboYbB=t0H7ASa99uou=Br5w88NFiEx==g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 5, 2020 at 10:47 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> Em ter., 3 de nov. de 2020 às 22:09, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> escreveu:
>> If we call WaitLatch(OrSocket) that waits on the latch, it immediately
>> returns because the latch is set. If we called ResetLatch before the
>> next call to WaitLatch(), it correctly waits on a trigger to be
>> pulled.
>
> +1
> The patch for me is syntactically equal to the code changed and
> avoids the dereference.

Thanks! Pushed.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2020-11-25 05:04:36 RE: POC: postgres_fdw insert batching
Previous Message Michael Paquier 2020-11-25 04:47:46 Re: A few new options for CHECKPOINT