From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: msys inet_pton strangeness |
Date: | 2024-09-28 20:52:52 |
Message-ID: | CA+hUKGJNW6rS11a=jcAOKE5jRa0vDAL_54k5HAFxXFKaMS2eRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Sep 29, 2024 at 6:26 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> We should have included ws2tcpip.h, which includes this:
>
> #define InetPtonA inet_pton
> WINSOCK_API_LINKAGE INT WSAAPI InetPtonA(INT Family, LPCSTR pStringBuf, PVOID pAddr);
>
> It's conditioned on (_WIN32_WINNT >= 0x0600), but that should be true.
Can you print out the value to be sure? I can't imagine they'd set it
lower themselves or make it go backwards in an upgrade, but perhaps
it's somehow not being set at all, and then we do:
#if defined(_MSC_VER) && _MSC_VER >= 1900
#define MIN_WINNT 0x0600
#else
#define MIN_WINNT 0x0501
#endif
In 16 we don't do that anymore, we just always set it to 0x0A00
(commit 495ed0ef2d72). And before 15, we didn't want that function
yet (commit c1932e542863).
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Kane | 2024-09-28 21:18:15 | ORDER BY operator index scans and filtering |
Previous Message | Tom Lane | 2024-09-28 19:49:56 | Re: msys inet_pton strangeness |