Re: Fixing order of resowner cleanup in 12, for Windows

On Mon, May 6, 2019 at 9:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, May 6, 2019 at 3:43 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Here's a way to produce an error which might produce the log message
> > on Windows. Does anyone want to try it?
>
> I can give it a try.

Thanks!

> > If it does produce the log message, then the attached patch should
> > make it go away.
>
> Are you referring to log message "LOG: could not rmdir directory
> "base/pgsql_tmp/pgsql_tmp3692.0.sharedfileset": Directory not empty"?

Yes.

> If so, I am getting it both before and after your patch.

Huh. I thought the only problem here was the phenomenon demonstrated
by [1]. I'm a bit stumped... if we've closed all the handles in every
backend before detaching, and then the last to detach unlinks all the
files first and then the directory, how can we get that error?

[1] https://www.postgresql.org/message-id/CAEepm%3D2rH_V5by1kH1Q1HZWPFj%3D4ykjU4JcyoKMNVT6Jh8Q_Rw%40mail.gmail.com

--
Thomas Munro
https://enterprisedb.com