| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Ildar Musin <ildar(at)adjust(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Duplicated LSN in ReorderBuffer |
| Date: | 2019-07-08 00:59:26 |
| Message-ID: | CA+hUKGJJDh7mExSSL8an=MidMCAvseZEQ6e_wmu_+-+FBjO6-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 26, 2019 at 2:46 AM Ildar Musin <ildar(at)adjust(dot)com> wrote:
> Attached is a simple patch that uses subxid instead of top-level xid
> in ReorderBufferAddNewTupleCids() call. It seems to fix the bug, but
> i'm not sure that this is a valid change. Can someone please verify it
> or maybe suggest a better solution for the issue?
Hello Ildar,
I hope someone more familiar with this code than me can comment, but
while going through the Commitfest CI results I saw this segfault with
your patch:
https://travis-ci.org/postgresql-cfbot/postgresql/builds/555184304
At a glance, HistoricSnapshotGetTupleCids() returned NULL in
HeapTupleSatisfiesHistoricMVCC(), so ResolveCminCmaxDuringDecoding()
blew up.
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-07-08 01:07:29 | Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3 |
| Previous Message | Thomas Munro | 2019-07-08 00:37:08 | Re: Built-in connection pooler |