| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com>, Chris Travers <chris(dot)travers(at)stormatics(dot)tech>, Farooq Rashed <farooq(dot)rashed(at)desc(dot)gov(dot)ae>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_rewind fails on Windows where tablespaces are used |
| Date: | 2025-01-09 03:38:54 |
| Message-ID: | CA+hUKGJDiwEtH3HnK8ZX=m1587jmHRCnnN_LP-cHCxUL6Gy59g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Jan 9, 2025 at 3:45 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Those patches didn't actually include any tests. I guess the best test
> would be to create a chain of several junction points and then run
> initdb on the leaf of the chain?
Yeah I think the three interesting cases were initdb when run under
junctions like these:
1. Volume GUID format: mklink /J foo \\?\Volume{12341234-1234...},
expected to break without patch
2. Chain: mklink /J C:\\aaa1 C:\\aaa2, mkdir /J C:\\aaa2 c:\\aaa3,
expected to break without patch
3. Chain of length > 8, expected to fail with ELOOP once the patch is applied.
(Syntax may be off, I just googled it but don't have Windows to try).
The way to get decent tests for this stuff and all the rest of the
wrappers would probably be to develop this test suite further:
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-01-09 03:44:17 | Re: BUG #18764: server closed the connection unexpectedly |
| Previous Message | David Rowley | 2025-01-09 03:30:43 | Re: BUG #18764: server closed the connection unexpectedly |