CI cpluspluscheck failures

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: CI cpluspluscheck failures
Date: 2024-08-18 12:10:40
Message-ID: CA+hUKGJC3d4PXkErpfOWrzQqcq6MLiCv0+AH0CMQnB6hdLUFEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The CompilerWarnings cspluspluscheck started failing recently.

1. LLVM library version issue. See commit message for details.
2. pg_verify_backup.h now uses simplehash.h, which references
pg_fatal(), which nobody declared.

I'm not sure why the first one started happening at the commit
(aa2d6b15) that caused the second one, I feel like I'm missing
something...

https://github.com/postgres/postgres/commits/master/

Anyway, these patches turn it green for me. Please see attached.

https://cirrus-ci.com/task/5014011601747968

Attachment Content-Type Size
0001-ci-Fix-cpluspluscheck-failure-due-to-LLVM-warnings.patch text/x-patch 2.0 KB
0002-ci-Placate-cpluspluscheck-about-pg_verifybackup.h.patch text/x-patch 831 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-08-18 13:35:55 Re: macOS prefetching support
Previous Message Alexander Lakhin 2024-08-18 12:00:00 Re: Remove dependence on integer wrapping