| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Dave Page <dpage(at)pgadmin(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows now has fdatasync() |
| Date: | 2022-07-20 04:48:58 |
| Message-ID: | CA+hUKGJA35X3Z_gOciqhOqyYf4Cc9dentHGF94GvSrUCLJT51A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 20, 2022 at 4:14 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Jul 20, 2022 at 4:08 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > On Wed, 20 Jul 2022 at 15:22, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > Ok, I've pushed the Windows patch. I'll watch the build farm to see
> > > if I've broken any of the frankentoolchain Windows animals.
> >
> > Just to get in there before the farm does... I just got a boatload of
> > redefinition of HAVE_FDATASYNC warnings. I see it already gets
> > defined in pg_config.h
> >
> > All compiles cleanly with the attached.
>
> Oops. Thanks, pushed.
... and here's a rebase of the patch that removes that macro stuff,
since cfbot is watching this thread.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-O_FSYNC-and-associated-macros.patch | text/x-patch | 5.2 KB |
| v2-0002-Remove-fdatasync-configure-probe.patch | text/x-patch | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-07-20 04:50:45 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Previous Message | David Rowley | 2022-07-20 04:43:03 | Re: Remove fls(), use pg_bitutils.h facilities instead? |